Lei Li has posted comments on this change. Change subject: add a new tool for auto-generate python entities from schema ......................................................................
Patch Set 7: I would prefer that you didn't submit this (4 inline comments) .................................................... File src/codegen/genparams.py Line 3: # Copyright (c) 2010 Red Hat, Inc. Should this be IBM? Line 64: \n Copyright (c) 2010 Red Hat, Inc.\ Same as above. Line 135: rc = subprocess.call(cmd, shell=True) I think it would be better to use a list wrapped cmd with shell=False by default. Line 137: print >> sys.stderr, "Execution failed:", e raise? -- To view, visit http://gerrit.ovirt.org/4880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916f63f1ac68ce2e31456a90c1291997f671af99 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
