Alon Bar-Lev has posted comments on this change. Change subject: build: add EXTRA_MAVEN_FLAGS make variable ......................................................................
Patch Set 1: (2 inline comments) .................................................... File Makefile Line 25: EXTRA_MAVEN_FLAGS= This what I had at beginning :) I decided to rename this as it also used for other maven targets. But not so important, I will resubmit. Line 60: $(MVN) clean $(EXTRA_MAVEN_FLAGS) To be consistent, so all invocations will execute using similar flags. And... for example, adding a specific profile. In my example, I don't have ~/.m2/settings.xml, so I pass the whole as settings to maven. -- To view, visit http://gerrit.ovirt.org/6054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87a81f08820e80cc09b20478dffc7b4e1c5fa554 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
