Juan Hernandez has posted comments on this change. Change subject: build: add EXTRA_MAVEN_FLAGS make variable ......................................................................
Patch Set 1: (2 inline comments) .................................................... File Makefile Line 25: EXTRA_MAVEN_FLAGS= I would rename this variable to EXTRA_BUILD_FLAGS. That or rename BUILD_FLAGS to MAVEN_FLAGS, just for consistency. Even it is easy to guess the intention of this variable, as it is is empty It would be nice to have a comment here explaining why this is needed, maybe with an example as you did in the commit message. Line 60: $(MVN) clean $(EXTRA_MAVEN_FLAGS) I can't foresee any reason to add extra flags (or any kind of flags) to the clean goal. -- To view, visit http://gerrit.ovirt.org/6054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87a81f08820e80cc09b20478dffc7b4e1c5fa554 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
