Martin Mucha has posted comments on this change. Change subject: core: MacPool related Commands ......................................................................
Patch Set 33: (3 comments) http://gerrit.ovirt.org/#/c/28705/33/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateMacPoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateMacPoolCommandTest.java: Line 11: public class UpdateMacPoolCommandTest { Line 12: Line 13: Line 14: @Test(expected = IllegalArgumentException.class) Line 15: public void testNullCannotBePassedToConstructor() throws Exception { > You should update the test name Done Line 16: UpdateMacPoolCommand.validateDefaultFlagIsNotChanged(null, new MacPool()); Line 17: } Line 18: Line 19: @Test(expected = IllegalArgumentException.class) Line 16: UpdateMacPoolCommand.validateDefaultFlagIsNotChanged(null, new MacPool()); Line 17: } Line 18: Line 19: @Test(expected = IllegalArgumentException.class) Line 20: public void testNullCannotBePassedToConstructor2() throws Exception { > Same here.. Also 2 is not a really good indication, a better one would be b you right, I've used 'testFirstParameterIsNotNull' and 'testSecondParameterIsNotNull' this will survive potential name refactoring in tested code. Done Line 21: UpdateMacPoolCommand.validateDefaultFlagIsNotChanged(new MacPool(), null); Line 22: } Line 23: Line 24: @Test http://gerrit.ovirt.org/#/c/28705/33/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 57: Line 58: @DefaultStringValue("Mac pool cannot be removed. Either it's used or it's default mac pool.") Line 59: String MAC_POOL_CANNOT_BE_REMOVED(); Line 60: Line 61: @DefaultStringValue("Cannot ${action} ${type}. ${type} does not exist.") > This is synced but most (if not all) of the other messages aren't. Done Line 62: String MAC_POOL_DOES_NOT_EXIST(); Line 63: Line 64: @DefaultStringValue("Mac pool cannot be created. Shared MAC pools must have names.") Line 65: String MAC_POOL_MUST_HAVE_NAME(); -- To view, visit http://gerrit.ovirt.org/28705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0c3657e3e53699bcafa375befdce848b01a2f3 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
