Martin Mucha has posted comments on this change. Change subject: core: MacPool related Commands ......................................................................
Patch Set 34: (2 comments) http://gerrit.ovirt.org/#/c/28705/34/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 55: @DefaultStringValue("Cannot ${action} ${type}. ${type} must contain at least one mac range.") Line 56: String ACTION_TYPE_FAILED_MAC_POOL_MUST_HAVE_RANGE(); Line 57: Line 58: @DefaultStringValue("Cannot ${action} ${type}. ${type} does not exist.") Line 59: String MAC_POOL_DOES_NOT_EXIST(); > This isn't used (the "action type" one with same name is used), so should b Done Line 60: Line 61: @DefaultStringValue("Cannot ${action} ${type}. ${type} must contain at least one mac range.") Line 62: String MAC_POOL_MUST_HAVE_RANGE(); Line 63: Line 58: @DefaultStringValue("Cannot ${action} ${type}. ${type} does not exist.") Line 59: String MAC_POOL_DOES_NOT_EXIST(); Line 60: Line 61: @DefaultStringValue("Cannot ${action} ${type}. ${type} must contain at least one mac range.") Line 62: String MAC_POOL_MUST_HAVE_RANGE(); > This isn't used (the "action type" one with same name is used), so should b Done Line 63: Line 64: @DefaultStringValue("Cannot delete Template. Template is being used by the following VMs: ${vmsList}.") Line 65: String VMT_CANNOT_REMOVE_DETECTED_DERIVED_VM(); Line 66: -- To view, visit http://gerrit.ovirt.org/28705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0c3657e3e53699bcafa375befdce848b01a2f3 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
