Oved Ourfali has posted comments on this change. Change subject: engine : Replace ACTIVE_ASYNC with async flag ......................................................................
Patch Set 4: After thinking and discussing it offline with Ravi, I think that for now we should eliminate the isAsync flag entirely. We will issue the callbacks for every command executor monitored command. It is the responsibility of the command to provide that, and if not needed don't do any logic there. I've suggested Ravi to have persistCommand and monitorCommandExecution, so that it will be clear when the command is just persisted, and when we are monitoring the execution of it. -- To view, visit http://gerrit.ovirt.org/30555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
