Yair Zaslavsky has posted comments on this change.

Change subject: engine : Replace ACTIVE_ASYNC with async flag
......................................................................


Patch Set 4:

Looks ok . but I have some idea - 
Ravi,
How about giving the ability to create a command as async? if you give this 
ability, then you will not to override isAsync flag in relevant commands, and 
it will be up to the caller to decide where to create command as sync or async.
thoughts?

-- 
To view, visit http://gerrit.ovirt.org/30555
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I382790a2f4042f2924a0916f62047790bb6d5e94
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to