Mike Kolesnik has posted comments on this change. Change subject: core: macPool per DC, db changes ......................................................................
Patch Set 39: (1 comment) http://gerrit.ovirt.org/#/c/26795/39/packaging/dbscripts/upgrade/03_05_0760_add_mac_pool_ranges_to_storage_pool.sql File packaging/dbscripts/upgrade/03_05_0760_add_mac_pool_ranges_to_storage_pool.sql: Line 1: CREATE TABLE mac_pools ( Line 2: id UUID NOT NULL PRIMARY KEY, Line 3: name CHARACTER VARYING(255), Line 4: description CHARACTER VARYING(4000), Line 5: allow_duplicate_mac_addresses BOOLEAN NOT NULL, > it depends, whether we want to allow not to send this on each request. I th I think Martin's explanation is valid, don't see why you need a default value here. >From business side perspective, I'd rather have the engine decide what's the >sensible default then let the DB choose for him. Also, I don't see that every NOT NULL field has a DEFAULT so not sure why this looked so disturbing to you. Line 6: default_pool BOOLEAN NOT NULL DEFAULT FALSE Line 7: ); Line 8: Line 9: CREATE TABLE mac_pool_ranges ( -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
