Eli Mesika has posted comments on this change. Change subject: core: macPool per DC, db changes ......................................................................
Patch Set 39: (14 comments) http://gerrit.ovirt.org/#/c/26795/39/packaging/dbscripts/mac_pools_sp.sql File packaging/dbscripts/mac_pools_sp.sql: Line 1: Create or replace FUNCTION Insertmac_pool( InsertMacPool or insert_mac_pool (not mixed) Line 2: v_id UUID, Line 3: v_name VARCHAR(40), Line 4: v_allow_duplicate_mac_addresses BOOLEAN, Line 5: v_description VARCHAR(4000)) Line 18: END; $procedure$ Line 19: LANGUAGE plpgsql; Line 20: Line 21: Line 22: Create or replace FUNCTION Updatemac_pool( same Line 23: v_id UUID, Line 24: v_name VARCHAR(40), Line 25: v_allow_duplicate_mac_addresses BOOLEAN, Line 26: v_description VARCHAR(4000)) Line 38: END; $procedure$ Line 39: LANGUAGE plpgsql; Line 40: Line 41: Line 42: Create or replace FUNCTION Deletemac_pool(v_id UUID) same Line 43: RETURNS VOID Line 44: AS $procedure$ Line 45: BEGIN Line 46: DELETE FROM mac_pools WHERE id=v_id; Line 47: END; $procedure$ Line 48: LANGUAGE plpgsql; Line 49: Line 50: Line 51: Create or replace FUNCTION Getmac_poolBymac_poolId(v_id UUID) RETURNS SETOF mac_pools STABLE same Line 52: AS $procedure$ Line 53: BEGIN Line 54: RETURN QUERY SELECT * Line 55: FROM mac_pools Line 58: Line 59: END; $procedure$ Line 60: LANGUAGE plpgsql; Line 61: Line 62: Create or replace FUNCTION GetDefaultmac_pool() RETURNS SETOF mac_pools STABLE same Line 63: AS $procedure$ Line 64: Line 65: BEGIN Line 66: RETURN QUERY SELECT * Line 69: Line 70: END; $procedure$ Line 71: LANGUAGE plpgsql; Line 72: Line 73: Create or replace FUNCTION Getmac_poolByDataCenterId(v_id UUID) RETURNS SETOF mac_pools STABLE same Line 74: AS $procedure$ Line 75: Line 76: BEGIN Line 77: RETURN QUERY SELECT mp.* Line 80: Line 81: END; $procedure$ Line 82: LANGUAGE plpgsql; Line 83: Line 84: CREATE OR REPLACE FUNCTION GetAllFrommac_pools() same Line 85: RETURNS SETOF mac_pools STABLE Line 86: AS $procedure$ Line 87: BEGIN Line 88: RETURN QUERY SELECT * Line 90: Line 91: END; $procedure$ Line 92: LANGUAGE plpgsql; Line 93: Line 94: CREATE OR REPLACE FUNCTION Getmac_poolUsageCountById(v_id UUID) same Line 95: RETURNS SETOF BIGINT STABLE Line 96: AS $procedure$ Line 97: BEGIN Line 98: RETURN QUERY SELECT count(*) Line 101: Line 102: END; $procedure$ Line 103: LANGUAGE plpgsql; Line 104: Line 105: CREATE OR REPLACE FUNCTION GetAllMacsBymac_poolId(v_id UUID) same Line 106: RETURNS SETOF VARCHAR STABLE Line 107: AS $procedure$ Line 108: BEGIN Line 109: RETURN QUERY SELECT mac_addr Line 119: LANGUAGE plpgsql; Line 120: Line 121: Line 122: -- Procedures for MAC ranges Line 123: Create or replace FUNCTION Insertmac_pool_range( same Line 124: v_mac_pool_id UUID, Line 125: v_from_mac CHARACTER VARYING(17), Line 126: v_to_mac CHARACTER VARYING(17)) Line 127: RETURNS VOID Line 137: END; $procedure$ Line 138: LANGUAGE plpgsql; Line 139: Line 140: Line 141: Create or replace FUNCTION Deletemac_pool_rangesByMacPoolId(v_id UUID) same Line 142: RETURNS VOID Line 143: AS $procedure$ Line 144: BEGIN Line 145: DELETE Line 148: END; $procedure$ Line 149: LANGUAGE plpgsql; Line 150: Line 151: Line 152: Create or replace FUNCTION GetAllmac_pool_rangesBymac_poolId(v_id UUID) same Line 153: RETURNS SETOF mac_pool_ranges STABLE Line 154: AS $procedure$ Line 155: BEGIN Line 156: RETURN QUERY http://gerrit.ovirt.org/#/c/26795/39/packaging/dbscripts/upgrade/03_05_0760_add_mac_pool_ranges_to_storage_pool.sql File packaging/dbscripts/upgrade/03_05_0760_add_mac_pool_ranges_to_storage_pool.sql: Line 1: CREATE TABLE mac_pools ( Script should be with 03_06 prefix Line 2: id UUID NOT NULL PRIMARY KEY, Line 3: name CHARACTER VARYING(255), Line 4: description CHARACTER VARYING(4000), Line 5: allow_duplicate_mac_addresses BOOLEAN NOT NULL, Line 5: allow_duplicate_mac_addresses Why not have a default for this if it is not null ??? -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
