Yair Zaslavsky has posted comments on this change. Change subject: Config tool: Get password via file or interactive console ......................................................................
Patch Set 1: Shahar, did not say this is that bad :) In general - this is the only thing that bothers me in the solution. Just suggested an alternative for this (I really don't see why the CliParser cannot be singletone) - it's a minor issue and I MHO (unless Doron thinks otherwise) you may proceed . -- To view, visit http://gerrit.ovirt.org/5943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0fe737e9d63ea5d066e31baa83126678e41fc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
