Alon Bar-Lev has posted comments on this change. Change subject: aaa: Optimizing fetchPrincipalIdsRecursively ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/29880/9/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 65: List<ExtMap> groups = new ArrayList<>(); Line 66: for (Entry<String, Set<String>> entry : idsToFetchPerNamespace.entrySet()) { Line 67: groups.addAll(findGroupRecordsByIds(extension, Line 68: namespace, Line 69: new ArrayList<String>(entry.getValue()), why can't the findGroupRecordsById get Collection? Line 70: true, Line 71: false)); Line 72: } Line 73: idsToFetchPerNamespace.clear(); -- To view, visit http://gerrit.ovirt.org/29880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I095bb91810e25d345fcd053cbd51d1d25a4b494d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
