Yair Zaslavsky has posted comments on this change. Change subject: aaa: Optimizing fetchPrincipalIdsRecursively ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/29880/6/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 61: } Line 62: } Line 63: while (!idsToFetch.isEmpty()) { Line 64: List<ExtMap> groups = Line 65: findGroupRecordsByIds(extension, namespace, new ArrayList<String>(idsToFetch), true, false); > oh! you should take the namespace from the group, so probably we need to do Don't all the entities in the same "tree" reside in the same namespace? I pass the namespace as argument the method. Line 66: idsToFetch.clear(); Line 67: for (ExtMap group : groups) { Line 68: groupsCache.put(group.<String> get(GroupRecord.ID), group); Line 69: for (ExtMap memberOf : group.get(GroupRecord.GROUPS, Collections.<ExtMap> emptyList())) { -- To view, visit http://gerrit.ovirt.org/29880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I095bb91810e25d345fcd053cbd51d1d25a4b494d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
