Yair Zaslavsky has posted comments on this change. Change subject: packaging, tools: Generate engine-config.xml from template ......................................................................
Patch Set 6: I saw that you implemented data source. Any reason why to continue and use data source here? Either than that, the code looks good to me, from Java side point of view. -- To view, visit http://gerrit.ovirt.org/5362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c8ff572307a31e5f9f9749e6c3cc41858a2765 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
