Yair Zaslavsky has posted comments on this change. Change subject: aaa: change code of AddUser and AddGroup ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/30039/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 72: log.info(String.format("The user %1$s from authz extension %2$s could not be found, and will be marked as inactive", Line 73: dbUser.getLoginName(), Line 74: dbUser.getDomain())); Line 75: dbUser.setActive(false); Line 76: DbFacade.getInstance().getDbUserDao().saveOrUpdate(dbUser); > while reviewing juan's comment, in this case we should not store user, we s i agree. Line 77: } Line 78: } Line 79: } catch (Exception ex) { Line 80: log.error(String.format("Error during user synchronization of extension %1$s. Exception message is %2$s", -- To view, visit http://gerrit.ovirt.org/30039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
