Alon Bar-Lev has posted comments on this change. Change subject: aaa: change code of AddUser and AddGroup ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/30039/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 26: Map<String, Map<String, Set<String>>> authzToNamespaceToUserIds = new HashMap<>(); Line 27: Map<DirectoryEntryKey, DbUser> originalDbUsersMap = new HashMap<>(); Line 28: Map<String, List<DbUser>> dbUsersPerAuthz = new HashMap<>(); Line 29: Line 30: DirectoryUtils.setDbUserIdsIfMissing(dbUsers); I thought caller should do this... or dbUsers within constructor has default random guid. but ok. Line 31: Line 32: //Initialize the entries based on authz in the map Line 33: for (DbUser dbUser : dbUsers) { Line 34: MultiValueMapUtils.addToMap(dbUser.getDomain(), dbUser, dbUsersPerAuthz); -- To view, visit http://gerrit.ovirt.org/30039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
