Omer Frenkel has posted comments on this change. Change subject: core: move vm numa fields to VmBase ......................................................................
Patch Set 4: (1 comment) looks ok, please rebase i think you are using old code (at least the dao classes has changed) http://gerrit.ovirt.org/#/c/28341/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java: Line 216: .addValue("serial_number_policy", template.getSerialNumberPolicy() == null ? null : template.getSerialNumberPolicy().getValue()) Line 217: .addValue("custom_serial_number", template.getCustomSerialNumber()) Line 218: .addValue("is_boot_menu_enabled", template.isBootMenuEnabled()) Line 219: .addValue("is_spice_file_transfer_enabled", template.isSpiceFileTransferEnabled()) Line 220: .addValue("numatune_mode", template.getNumaTuneMode().getValue()) when you rebase, this will not be needed anymore Line 221: .addValue("is_spice_copy_paste_enabled", template.isSpiceCopyPasteEnabled()); Line 222: } Line 223: Line 224: @Override -- To view, visit http://gerrit.ovirt.org/28341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc69f8167b8468becef728617ec850dc9034d88f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
