Xiaolei Shi has posted comments on this change. Change subject: core: move vm numa fields to VmBase ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/28341/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 218: @EditableField Line 219: @Min(value = 0, message = "VALIDATION.VM.MIGRATION_DOWNTIME_RANGE") Line 220: private Integer migrationDowntime; Line 221: Line 222: private NumaTuneMode numaTuneMode; > these fields are not editable/onStatus? Yes, it's editable. Thanks. Line 223: Line 224: private List<VmNumaNode> vNumaNodeList; Line 225: Line 226: public VmBase() { Line 328: @CopyOnNewVersion Line 329: @EditableOnVmStatusField Line 330: @EditableOnTemplate Line 331: private boolean spiceCopyPasteEnabled; Line 332: > please update copy ctor Done Line 333: public VmBase(VmBase vmBase) { Line 334: this(vmBase.getName(), Line 335: vmBase.getId(), Line 336: vmBase.getVdsGroupId(), Line 425: VmInit vmInit, Line 426: SerialNumberPolicy serialNumberPolicy, Line 427: String customSerialNumber, Line 428: boolean bootMenuEnabled, Line 429: boolean spiceFileTransferEnabled, > please add here, then you discover you are missing also template ctor and A Done Line 430: boolean spiceCopyPasteEnabled) { Line 431: this(); Line 432: this.name = name; Line 433: this.id = id; -- To view, visit http://gerrit.ovirt.org/28341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc69f8167b8468becef728617ec850dc9034d88f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
