Tomas Jelinek has posted comments on this change.

Change subject: ui: line chart progress bar
......................................................................


Patch Set 13:

> looks amazing! :) good job, Tomas!

Thank you! My secret here is to drop all my own creativity and exactly follow 
the mockup by Maliny and you :D

> a couple of small questions:
> what is the default width of the MEM/CPU/NET columns in the grid, and what is 
> being displayed in that width (maybe another screen-shot to 
> visualize that)?

It was 60px (screenshot: http://i60.tinypic.com/24ezvp1.png)
But looking at it I found it too small so enriched it by 10px to 70 taking this 
from other parts in a way they still fit in (this is the last patchset). 
Screenshot: http://i59.tinypic.com/2vsgu8n.jpg

> the same widget can be utilized for the MEM/CPU/NET in the Hosts main tab, 
> assuming that the Host business entity will have the same short 
> term history data of cpu/memory/network usage (like the one added for the VM 
> business entity in http://gerrit.ovirt.org/#/c/29710/), 
> correct?

yes, correct. When the VM will be done we can discuss if we want to do it also 
for the hosts.

-- 
To view, visit http://gerrit.ovirt.org/29549
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66a577d6e3699c7985a4e6dd4aa66dd5969ebf82
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to