Tomas Jelinek has posted comments on this change. Change subject: ui: line chart progress bar ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/29549/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java: Line 399: abstract class ColumnResizeTableLineChartProgressBar extends LineChartProgressBar<VM> { Line 400: Line 401: @Override Line 402: protected String getActualWidth() { Line 403: return ((ColumnResizeCellTable) getTable().table).getColumnWidth(this); > AbstractActionTable.table field is public (due to how @WithElementId annota I was actually considering this but than I decided that I do not want to enrich the AbstractActionTable if there is already a public 'table'. But you are absolutely right, the reason why the table is public is not because it is part of it's API so I will not use it - done. Line 404: } Line 405: } Line 406: Line 407: private List<Integer> asListOfIntegers(String str) { http://gerrit.ovirt.org/#/c/29549/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/LineChartProgressBar.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/LineChartProgressBar.java: Line 26: * - if no points fit into the drawing area, only the number is shown Line 27: * Line 28: * @param <T> The entity type Line 29: */ Line 30: public abstract class LineChartProgressBar<T> extends SafeHtmlColumn<T> { > Maybe add "Column" to the name of this class? :-) ok :) Line 31: Line 32: private static final ApplicationTemplates applicationTemplates = ClientGinjectorProvider.getApplicationTemplates(); Line 33: Line 34: private static final int stepMax = 15; Line 64: private FallbackProgressColumn fallbackProgressColumn; Line 65: Line 66: @Override Line 67: public SafeHtml getValue(T object) { Line 68: final Canvas canvas = Canvas.createIfSupported(); > Code in this class uses HTML5 <canvas> element as a 2D graphics engine, wit Done Line 69: if (canvas == null) { Line 70: // lazily - normally the browser should support it Line 71: if (fallbackProgressColumn == null) { Line 72: fallbackProgressColumn = new FallbackProgressColumn(); -- To view, visit http://gerrit.ovirt.org/29549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66a577d6e3699c7985a4e6dd4aa66dd5969ebf82 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
