Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fixing Sync ......................................................................
Patch Set 23: (1 comment) http://gerrit.ovirt.org/#/c/29706/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 56: } Line 57: } Line 58: Line 59: for (DbUser dbUser : dbUsersPerAuthz.get(authz)) { Line 60: if (activeUsers.containsKey(dbUser.getExternalId())) { > why not just get and test for null? i'll fix and merge. Line 61: DbUser activeUser = activeUsers.get(dbUser.getExternalId()); Line 62: if (!activeUser.equals(dbUser)) { Line 63: activeUser.setId(dbUser.getId()); Line 64: log.info(String.format("The user %1$s from authz extension %2$s got updated since last interval", -- To view, visit http://gerrit.ovirt.org/29706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a66a7c235f16ff26cac3a779de688c73d67f4a2 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
