Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fixing Sync ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/29706/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 89: } Line 90: } Line 91: } Line 92: Line 93: private static List<DbUser> copyUsersAndKeepIdInfo(Collection<DbUser> dbUsers) { > When creating the non active list, all we care of are the external id and t so all you need is alternate equals, no? one that is per id only? or do this in reverse? hold a set ids and subtract? this copy just to make java happy is not good. Line 94: List<DbUser> result = new ArrayList<>(dbUsers.size()); Line 95: for (DbUser dbUser : result) { Line 96: DbUser copy = new DbUser(); Line 97: copy.setExternalId(dbUser.getExternalId()); -- To view, visit http://gerrit.ovirt.org/29706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a66a7c235f16ff26cac3a779de688c73d67f4a2 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
