Ravi Nori has posted comments on this change. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname ......................................................................
Patch Set 1: Verified+1 (1 comment) I will remove 'sn' after Mooli and Alon review, I could not find a path where 'sn' is being sent http://gerrit.ovirt.org/#/c/29894/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java: Line 31: static { Line 32: attributesToKeys.put("$GIVENNAME", Authz.PrincipalRecord.FIRST_NAME); Line 33: attributesToKeys.put("$SAMACCOUNTNAME", Authz.PrincipalRecord.NAME); Line 34: attributesToKeys.put("$USER_ACCOUNT_NAME", Authz.PrincipalRecord.DISPLAY_NAME); Line 35: attributesToKeys.put("sn", Authz.PrincipalRecord.LAST_NAME); > 1. please check if "sn" is needed. 1. I dont see a path where 'sn' is being send 2. LdapQueryMetadataFactoryImpl has $SN 3. I have added them as reviewers, after they confirm I will remove 'sn' Line 36: attributesToKeys.put("$SN", Authz.PrincipalRecord.LAST_NAME); Line 37: attributesToKeys.put("$DEPARTMENT", Authz.PrincipalRecord.DEPARTMENT); Line 38: attributesToKeys.put("$TITLE", Authz.PrincipalRecord.TITLE); Line 39: attributesToKeys.put("$CN", Authz.GroupRecord.NAME); -- To view, visit http://gerrit.ovirt.org/29894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I294d415201f155d263d588b5a21f803c0870cb95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
