Yair Zaslavsky has posted comments on this change. Change subject: core : [AAA] NPE is raised when searching user in domain by lastname ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29894/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java: Line 31: static { Line 32: attributesToKeys.put("$GIVENNAME", Authz.PrincipalRecord.FIRST_NAME); Line 33: attributesToKeys.put("$SAMACCOUNTNAME", Authz.PrincipalRecord.NAME); Line 34: attributesToKeys.put("$USER_ACCOUNT_NAME", Authz.PrincipalRecord.DISPLAY_NAME); Line 35: attributesToKeys.put("sn", Authz.PrincipalRecord.LAST_NAME); 1. please check if "sn" is needed. 2. please check with LdapQueryMetadataFactoryImpl - although "legacy provider" code - has to be supported - make sure $SN exists there 3. Make sure Alon is notified when it comes to generic ldap provider configuration (maybe Mooli needs to be notified as well, as he works on the jdbc provider) Line 36: attributesToKeys.put("$SN", Authz.PrincipalRecord.LAST_NAME); Line 37: attributesToKeys.put("$DEPARTMENT", Authz.PrincipalRecord.DEPARTMENT); Line 38: attributesToKeys.put("$TITLE", Authz.PrincipalRecord.TITLE); Line 39: attributesToKeys.put("$CN", Authz.GroupRecord.NAME); -- To view, visit http://gerrit.ovirt.org/29894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I294d415201f155d263d588b5a21f803c0870cb95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
