Mike Kolesnik has posted comments on this change. Change subject: core: Sometimes getting exception when trying to preview snapshots (#836162) ......................................................................
Patch Set 2: Looks good to me, approved (4 inline comments) .................................................... File backend/manager/dbscripts/snapshots_sp.sql Line 144: WHERE vm_id = v_vm_id I believe that this is already exists implicitly since vm_id is a foreign key to the VM table. Either way, this is for another patch if it's not the case. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java Line 113: snapshotsManager.addActiveSnapshot(newActiveSnapshotId, getVm(), getCompensationContext()); Right, missed that Line 114: snapshotsManager.removeAllIllegalDisks(previousActiveSnapshotId); Yes you are correct, this should be handled at a separate patch that fixes also the EndWithFailure to return these disks. Line 135: tempVar.setParentParemeters(getParameters()); Agreed. -- To view, visit http://gerrit.ovirt.org/5825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07ec66f6c725827526250a03e04f133783ed7270 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
