Mike Kolesnik has posted comments on this change. Change subject: core: Sometimes getting exception when trying to preview snapshots (#836162) ......................................................................
Patch Set 2: (3 inline comments) This bug can also happen for CreateAllSnapshots .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java Line 113: snapshotsManager.addActiveSnapshot(newActiveSnapshotId, getVm(), getCompensationContext()); Should also snapshot (for compensation) here the newly added active snapshot (so that it's deleted in the end). Line 114: snapshotsManager.removeAllIllegalDisks(previousActiveSnapshotId); Should also snapshot (for compensation) the disks that are removed. Line 135: tempVar.setParentParemeters(getParameters()); Should set compensation context somehow on the son command? -- To view, visit http://gerrit.ovirt.org/5825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07ec66f6c725827526250a03e04f133783ed7270 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
