Michael Pasternak has posted comments on this change.

Change subject: restapi: LunStatus Enum and CreateVG force flag
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
Line 102:         boolean overrideLuns = model.getStorage().isOverrideLuns() != 
null ?
isOverrideLuns() operate on the value, so basically you stil have NPE here 
when OverrideLuns is NULL,

do: 

model.getStorage().isSetOverrideLuns() ? model.getStorage().isOverrideLuns() : 
false;

--
To view, visit http://gerrit.ovirt.org/5732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97615bf04c40f580d56352cb022530b5a0043192
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to