Michael Pasternak has posted comments on this change.

Change subject: restapi: LunStatus Enum and CreateVG force flag
......................................................................


Patch Set 5: (3 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 639:         optionalArguments: {storagdomain.storage.force: 'xs:boolean'}
override_luns not force

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
Line 106:                                                
model.getStorage().isOverrideLuns()),
potential NPE when OverrideLuns is NULL

....................................................
Commit Message
Line 16: * api: added 'force' boolean to 'IscsiStorage' type.
pls. change /force accordingly

--
To view, visit http://gerrit.ovirt.org/5732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97615bf04c40f580d56352cb022530b5a0043192
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to