Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix sync ......................................................................
Patch Set 14: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/29706/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 67: removeAll(activeUsers); Line 68: } Line 69: }; Line 70: Line 71: for (DbUser inactiveUser: inactiveUsers) { we also have a bug here... these two loops should be per authz within the above loop, so that if extension is missing or an error we do not update the extensions' users but continue to next. it also means that the set of inactiveUsers should be acquired a little differently. Line 72: inactiveUser.setActive(false); Line 73: log.info(String.format("The user %1$s from authz extension %2$s could not be found, and will be marked as inactive", inactiveUser.getLoginName(), inactiveUser.getDomain())); Line 74: DbFacade.getInstance().getDbUserDao().update(inactiveUser); Line 75: } -- To view, visit http://gerrit.ovirt.org/29706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a66a7c235f16ff26cac3a779de688c73d67f4a2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
