Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix sync ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/29706/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java: Line 47: ExtMap principal : Line 48: AuthzUtils.fetchPrincipalsByIdsRecursively( Line 49: authzExtension, userIdsPerNamespace.getKey(), Line 50: new ArrayList<String>(userIdsPerNamespace.getValue())) Line 51: ) { hmmm... we need to manage error from extension from this... and not blow the entire sync for single error. Line 52: DirectoryUtils.flatGroups(principal); Line 53: DbUser dbUser = DirectoryUtils.mapPrincipalRecordToDbUser(authz, principal); Line 54: dbUser.setGroupIds(DirectoryUtils.getGroupIdsFromPrincipal(authz, principal)); Line 55: activeUsers.add(dbUser); -- To view, visit http://gerrit.ovirt.org/29706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a66a7c235f16ff26cac3a779de688c73d67f4a2 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
