Alon Bar-Lev has posted comments on this change. Change subject: core: sort domain names a-b ascending, 'internal' always last. ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29721/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-07-08 19:26:18 +0300 Line 4: Commit: Mooli Tayer <mta...@redhat.com> Line 5: CommitDate: 2014-07-08 19:26:18 +0300 Line 6: Line 7: core: sort domain names a-b ascending, 'internal' always last. aaa: Line 8: Line 9: Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115549 Line 4: Commit: Mooli Tayer <mta...@redhat.com> Line 5: CommitDate: 2014-07-08 19:26:18 +0300 Line 6: Line 7: core: sort domain names a-b ascending, 'internal' always last. Line 8: please add: Topic: AAA so we can track this Line 9: Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115549 http://gerrit.ovirt.org/#/c/29721/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java: Line 25: names.add(profile.getName()); Line 26: } Line 27: Line 28: // Sort it so that the internal profile is always the last: Line 29: sort(names, new LoginDomainComparator(Config.<String> getValue(ConfigValues.AdminDomain))); > as far as I know the value of the internal domain is indeed set by the Admi no reason for exception in sorting. Yair, I thought we are already handled that sort? maybe at frontend? Line 30: Line 31: getQueryReturnValue().setReturnValue(names); Line 32: } Line 33: -- To view, visit http://gerrit.ovirt.org/29721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
