Oved Ourfali has posted comments on this change. Change subject: core: sort domain names a-b ascending, 'internal' always last. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29721/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java: Line 25: names.add(profile.getName()); Line 26: } Line 27: Line 28: // Sort it so that the internal profile is always the last: Line 29: sort(names, new LoginDomainComparator(Config.<String> getValue(ConfigValues.AdminDomain))); > Not sure if there is an "internal" profile any longer, or if its name has a as far as I know the value of the internal domain is indeed set by the AdminDomain entry, but @Alon/@Yair - please comment on that. Anyway, also don't see a reason to put it last. I'd keep it simple and just sort all the domains (including the internal one). Line 30: Line 31: getQueryReturnValue().setReturnValue(names); Line 32: } Line 33: -- To view, visit http://gerrit.ovirt.org/29721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
