Allon Mureinik has posted comments on this change. Change subject: core: Adding force creation support to CreateVG ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java Line 668: Map<String, Object> xmlRpcReturnValue = vdsServer.createVG(sdUUID, deviceList, force); I must I disagree, but it's a matter of style. Consider though documenting the fact that the other method's days are numbered. -- To view, visit http://gerrit.ovirt.org/5729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id210012a25f8608b8404155be7f7c44642122dc2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
