Allon Mureinik has posted comments on this change.
Change subject: core: Adding force creation support to CreateVG
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(9 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVGVDSCommandParameters.java
Line 14: private ArrayList<String> privateDeviceList;
Can't this be a List instead of an ArrayList?
Line 16: public ArrayList<String> getDeviceList() {
Here too.
Line 39: return String.format("%s, deviceList=%s", super.toString(),
getDeviceList());
Add the force parameter to the toString()
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVGVDSCommand.java
Line 19: String[] deviceList =
getParameters().getDeviceList().toArray(new String[] {});
performance: init the string away with the size of the device list
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
Line 139
shouldn't this be part of the previous patch?
how is it connected to this patch?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 130
here too - how is this related to this patch?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
Line 668: Map<String, Object> xmlRpcReturnValue =
vdsServer.createVG(sdUUID, deviceList, force);
most of the code here (actually: all of it except the call to
vdsServer.createVG) is shared with the overloaded method createVG.
Consider extracting it to a private helper function.
Line 702
here too - how is this related to this patch?
....................................................
Commit Message
Line 11: * Passing 'force' flag to CreateVG iff 'SupportForceCreateVG' is true.
Please keep the commit message in a consistent tense.
If you're used "added", also use "passed".
--
To view, visit http://gerrit.ovirt.org/5729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id210012a25f8608b8404155be7f7c44642122dc2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
