Moti Asayag has posted comments on this change. Change subject: core: avoid findbug issues for encoding and bare exceptions catch ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28824/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 306: @Override Line 307: public long getContentLength() { Line 308: long len = 0; Line 309: len = entityBody.getBytes(StandardCharsets.UTF_8).length; Line 310: return len; len can be inlined: return entityBody.getBytes(StandardCharsets.UTF_8).length; Line 311: } Line 312: Line 313: @Override Line 314: public String getContentType() { -- To view, visit http://gerrit.ovirt.org/28824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f87ad979954807feb68c5fa971da246b01beaef Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
