Moti Asayag has posted comments on this change. Change subject: core: avoid findbug issues for encoding and bare exceptions catch ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28824/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 297: } Line 298: Line 299: @Override Line 300: public void writeRequest(OutputStream outputStream) throws IOException { Line 301: PrintWriter pr = new PrintWriter(new OutputStreamWriter(outputStream, "UTF-8")); you should be able to replace it with StandardCharsets.UTF_8, instead passing UTF-8 as string. Line 302: pr.println(entityBody); Line 303: pr.flush(); Line 304: } Line 305: Line 306: @Override Line 307: public long getContentLength() { Line 308: long len = 0; Line 309: try { Line 310: len = entityBody.getBytes("UTF-8").length; same Line 311: } catch (UnsupportedEncodingException e) { Line 312: handleException(e); Line 313: } Line 314: return len; -- To view, visit http://gerrit.ovirt.org/28824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f87ad979954807feb68c5fa971da246b01beaef Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
