Liron Aravot has posted comments on this change. Change subject: core, db: Introduce BaseProfile and DiskProfile ......................................................................
Patch Set 15: Code-Review+1 (4 comments) looks good, just please move some changes to their related patches. http://gerrit.ovirt.org/#/c/27099/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java: Line 34: PROVIDER(24, "Provider"), Line 35: GlusterService(25, "GlusterService"), Line 36: ExternalTask(26, "ExternalTask"), Line 37: VnicProfile(27, "Vnic Profile"), Line 38: DiskProfile(28, "Disk Profile"); seems like this should be in the patch in which you introduced the disk profiles Line 39: Line 40: private int value; Line 41: private String vdcObjectTranslationVal; Line 42: private static final Map<Integer, VdcObjectType> map = new HashMap<Integer, VdcObjectType>(values().length); http://gerrit.ovirt.org/#/c/27099/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java: Line 136: Line 137: // disk profiles Line 138: CONFIGURE_STORAGE_DISK_PROFILE(1560, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 139: CREATE_STORAGE_DISK_PROFILE(1561, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 140: DELETE_STORAGE_DISK_PROFILE(1562, RoleType.ADMIN, true, ApplicationMode.VirtOnly); wrong patch Line 141: Line 142: private int id; Line 143: private RoleType roleType; Line 144: private boolean allowsViewingChildren; http://gerrit.ovirt.org/#/c/27099/15/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java: Line 119: Line 120: // disk profile Line 121: CONFIGURE_STORAGE_DISK_PROFILE, Line 122: CREATE_STORAGE_DISK_PROFILE, Line 123: DELETE_STORAGE_DISK_PROFILE; wrong patch Line 124: Line 125: public String value() { Line 126: return name().toLowerCase(); Line 127: } http://gerrit.ovirt.org/#/c/27099/15/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java: Line 196: return PermitType.CONFIGURE_STORAGE_DISK_PROFILE; Line 197: case CREATE_STORAGE_DISK_PROFILE: Line 198: return PermitType.CREATE_STORAGE_DISK_PROFILE; Line 199: case DELETE_STORAGE_DISK_PROFILE: Line 200: return PermitType.DELETE_STORAGE_DISK_PROFILE; wrong patch Line 201: default: Line 202: return null; Line 203: } Line 204: } -- To view, visit http://gerrit.ovirt.org/27099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229af59277b5055453188f002f19046cdd51d63b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
