Liron Aravot has posted comments on this change. Change subject: core, db: Introduce BaseProfile and DiskProfile ......................................................................
Patch Set 16: -Code-Review (2 comments) Still requiring some changes, removing -1 to not block. http://gerrit.ovirt.org/#/c/27099/16/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java: Line 111: * Ensures that the remove is working correctly Line 112: */ Line 113: @Test Line 114: public void testRemove() { Line 115: dao.save(diskProfile); > * the order of test isn't deterministic., prefer to save and remove. - the changes made by the tests are rolled back, so it shouldn't be visible from other test. Line 116: DiskProfile result = dao.get(diskProfile.getId()); Line 117: assertNotNull(result); Line 118: dao.remove(diskProfile.getId()); Line 119: assertNull(dao.get(diskProfile.getId())); http://gerrit.ovirt.org/#/c/27099/16/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 4980: <value>77296e00-0cad-4e5a-9299-008a7b6f4354</value> Line 4981: </row> Line 4982: </table> Line 4983: Line 4984: <table name="disk_profiles"> > testGetAll.count = 5 we can also have 2 there, if we don't use the records in actual test, there's no need to add them..if we use 2, let's have 2 here. this file is already long enough. Line 4985: <column>id</column> Line 4986: <column>name</column> Line 4987: <column>storage_domain_id</column> Line 4988: <column>qos_id</column> -- To view, visit http://gerrit.ovirt.org/27099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229af59277b5055453188f002f19046cdd51d63b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
