Liron Aravot has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
Patch Set 3: (2 inline comments)
response to mkublin comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 90: VmHandler.updateDisksForVm(getVm(), imageList);
when we add a disk to a vm (AddDiskCommand) we set the VM active snapshot id to
the disk's image , in this case of attaching a disk - this part was missing and
it caused errors as part of the flow was missing in this command (a different
implementation though).
Line 119: private void updateDiskVmSnapshotId() {
at this moment, it is - but if a future different type of disk would support it
and would require a different handling, it might break the flow, so this if
specifies that this handling is relevant to image types only which are the
currently supported type.
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
