Liron Aravot has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
Patch Set 6: (1 inline comment)
answered abaron comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 124: if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
regarding the IF - it's basically there to provide safety in case that another
future disk type would support snapshots, the meaning is - 'for this kind of a
disk storage type, this is the required treatment' and is there to avoid some
default implementation for this kind of operation. if another disk storage type
would support snapshots, we could replace the if with switch case (used if at
the moment because i didn't see a point in using a switch when atm there is
only one case).
regarding the name - this is private helper method which is used only after
disk.isAllowSnapshot() is checked and appears to be true, so basically it
should always update the snapshotId.
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
