Moti Asayag has posted comments on this change. Change subject: engine: Bind port to agent when port is being activated ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/28792/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java: Line 252: portForCreate.setSecurityGroups(securityGroups); Line 253: portForCreate.setBinding(new Binding()); Line 254: portForCreate.getBinding().setHostId(hostId); Line 255: port = getClient().ports().create(portForCreate).execute(); Line 256: } else { per mike's request, i've changed a bit the implementation of this block to send the host-id only when relevant. Line 257: boolean securityGroupsChanged = securityGroupsChanged(port.getSecurityGroups(), securityGroups); Line 258: boolean hostChanged = hostChanged(port, hostId); Line 259: Line 260: if (securityGroupsChanged || hostChanged) { -- To view, visit http://gerrit.ovirt.org/28792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cb5bf95054b6d2711f88a09d374a74f156a4055 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
