Moti Asayag has posted comments on this change. Change subject: engine: Bind port to agent when port is being activated ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/28792/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 529: return parameters; Line 530: } Line 531: Line 532: protected void initParametersForExternalNetworks() { Line 533: if (getVm().getInterfaces().isEmpty()) { > This should be pushed in a separate patch since it's not related.. this is the same logic which exists on the left side, before calling to this method. Line 534: return; Line 535: } Line 536: Line 537: Map<VmDeviceId, VmDevice> nicDevices = -- To view, visit http://gerrit.ovirt.org/28792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cb5bf95054b6d2711f88a09d374a74f156a4055 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
