Martin Mucha has posted comments on this change. Change subject: core: macPool per DC, db changes ......................................................................
Patch Set 33: (2 comments) answers. http://gerrit.ovirt.org/#/c/26795/33/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java: Line 83: this.description = description; Line 84: } Line 85: Line 86: @Override Line 87: public boolean equals(Object o) { > * Generally all fields are checked, not sure it's the best approach but tha well I cannot see problem with null values you're talking about, and I would almost swear that 31 is a prime number. So I don't know what do you talking about in second point. send me an example what you would expect to see instead. Line 88: if (this == o) { Line 89: return true; Line 90: } Line 91: if (!(o instanceof MacPool)) { http://gerrit.ovirt.org/#/c/26795/33/packaging/dbscripts/upgrade/03_05_0720_add_mac_pool_ranges_to_storage_pool.sql File packaging/dbscripts/upgrade/03_05_0720_add_mac_pool_ranges_to_storage_pool.sql: Line 34: INSERT INTO mac_pool_ranges (mac_pool_id, Line 35: from_mac, Line 36: to_mac) Line 37: SELECT (SELECT id FROM mac_pools), Line 38: mac_range[1], > Normally you're right, but since upgrade is a delicate procedure that if fa ok. And how about exclamation marks? Should I handle them as well? User can enter them also. How about endash or emdash (—)instead of hyphen(-), shouldn't this be also covered? Maybe even tilde ~ can be confused with hyphen by visualy impaired users. I know that I'm quite sarcastic, but this is hell ridiculous. Once you're talking about neccessity to do statistical analysis to justify trivial change, defend using crappy implementation by misinterpretting "premature optimization rule", and now you're just making bold guesses supported by nothing. Line 39: mac_range[2] Line 40: FROM (SELECT string_to_array(unnest(string_to_array(option_value, ',')),'-') as mac_range Line 41: FROM vdc_options Line 42: WHERE option_name = 'MacPoolRanges') as mac_ranges; -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
