Mike Kolesnik has posted comments on this change.

Change subject: core: macPool per DC, db changes
......................................................................


Patch Set 34: Code-Review-1

(1 comment)

Please see comments on patchset #33

http://gerrit.ovirt.org/#/c/26795/34/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java:

Line 2: 
Line 3: import java.security.MessageDigest;
Line 4: import java.security.NoSuchAlgorithmException;
Line 5: 
Line 6: import org.ovirt.engine.core.compat.Guid;
This file shouldn't be part of this patch at all..
Line 7: 
Line 8: public class GuidUtils {
Line 9: 
Line 10:     private static final String MD5_SECURITY_ALGORITHM = "MD5";


-- 
To view, visit http://gerrit.ovirt.org/26795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca
Gerrit-PatchSet: 34
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to