Tomas Jelinek has posted comments on this change. Change subject: ui: Enhance to multi line list box for discovered hosts info ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/29124/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 157: Line 158: @UiField(provided = true) Line 159: @Path(value = "externalDiscoveredHosts.selectedItem") Line 160: @WithElementId("externalDiscoveredHosts") Line 161: ListModelTypeAheadListBoxEditor<Object> externalDiscoveredHostsEditor; We already support generic EntityModel and ListModel. So there is no need to use <Object> anymore, you can have the HostModel.privateExternalDiscoveredHosts declared as ListModel<ExternalDiscoveredHost>, than this type ahead as: ListModelTypeAheadListBoxEditor<ExternalDiscoveredHost> so the renderer will not need the hard casts, because it also will be declared as NullSafeSuggestBoxRenderer<ExternalDiscoveredHost>. For examples please look around in e.g. HostModel and this class. Line 162: Line 163: @UiField(provided = true) Line 164: @Path(value = "externalHostGroups.selectedItem") Line 165: @WithElementId("externalHostGroups") Line 162: Line 163: @UiField(provided = true) Line 164: @Path(value = "externalHostGroups.selectedItem") Line 165: @WithElementId("externalHostGroups") Line 166: ListModelTypeAheadListBoxEditor<Object> externalHostGroupsEditor; same Line 167: Line 168: @UiField(provided = true) Line 169: @Path(value = "externalComputeResource.selectedItem") Line 170: @WithElementId("externalComputeResource") Line 167: Line 168: @UiField(provided = true) Line 169: @Path(value = "externalComputeResource.selectedItem") Line 170: @WithElementId("externalComputeResource") Line 171: ListModelTypeAheadListBoxEditor<Object> externalComputeResourceEditor; same Line 172: Line 173: @UiField Line 174: @Path(value = "host.entity") Line 175: @WithElementId("host") -- To view, visit http://gerrit.ovirt.org/29124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
