Yaniv Bronhaim has posted comments on this change. Change subject: ui: Enhance to multi line list box for discovered hosts info ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/29124/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java: Line 565: new ListModelTypeAheadListBoxEditor.NullSafeSuggestBoxRenderer<Object>() { Line 566: Line 567: @Override Line 568: public String getReplacementStringNullSafe(Object data) { Line 569: ExternalDiscoveredHost host = (ExternalDiscoveredHost)data; > please use formatter on the modified code... Done Line 570: return host.getName(); Line 571: } Line 572: Line 573: @Override Line 571: } Line 572: Line 573: @Override Line 574: public String getDisplayStringNullSafe(Object data) { Line 575: ExternalDiscoveredHost host = (ExternalDiscoveredHost)data; > suggestion - can we have a common interface for ExternalDiscoveredHost, E good idea. will post it in following patch Line 576: return typeAheadNameDescriptionTemplateNullSafe( Line 577: host.getName(), Line 578: host.getDescription() Line 579: ); Line 632: } Line 633: Line 634: private String typeAheadNameDescriptionTemplateNullSafe(String name, String description) { Line 635: return applicationTemplates.typeAheadNameDescription( Line 636: name != null ? name : "", > use 'constants.empty()' (btw, adding //$NON-NLS-1$ is mandatory when using Done Line 637: description != null ? description : "") Line 638: .asString(); Line 639: } Line 640: Line 633: Line 634: private String typeAheadNameDescriptionTemplateNullSafe(String name, String description) { Line 635: return applicationTemplates.typeAheadNameDescription( Line 636: name != null ? name : "", Line 637: description != null ? description : "") > same Done Line 638: .asString(); Line 639: } Line 640: Line 641: void localize(ApplicationConstants constants) { -- To view, visit http://gerrit.ovirt.org/29124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3013e6c27f214c92acd50f1867ae84e2e25fcf75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
