Tal Nisan has posted comments on this change. Change subject: webadmin: enable import data domains on storage dialog ......................................................................
Patch Set 13: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/28833/13/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java: Line 239: storageView = new PosixStorageView(); Line 240: } else if (model.getType() == StorageType.GLUSTERFS) { Line 241: storageView = new GlusterStorageView(); Line 242: } else if (model.getType() == StorageType.FCP) { Line 243: if (!object.getBehavior().isImport()) { I generally dislike the negative approach, if not import then... why not change it to if import then? makes it more logical if (object.getBehavior().isImport()) Line 244: storageView = new FcpStorageView(true); Line 245: } Line 246: else { Line 247: storageView = new ImportFcpStorageView(); -- To view, visit http://gerrit.ovirt.org/28833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fab33f28995a59849341541d85b6758de82a34b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
