Tal Nisan has posted comments on this change. Change subject: webadmin: import iSCSI data storage domain dialog ......................................................................
Patch Set 9: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/29173/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java: Line 111: Line 112: protected boolean isLocalStorage(IStorageModel storage) { Line 113: return storage.getType() == StorageType.LOCALFS; Line 114: } Line 115: We have isNew, now isImport, we might as well make an enum that contains the type of operation Not now but in general Line 116: public abstract boolean isImport(); -- To view, visit http://gerrit.ovirt.org/29173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If379f5e41544fda90cb3e31e38784b768c994e5c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
