Maor Lipchuk has posted comments on this change. Change subject: core: Change GetStorageDomainInfo return value ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/29146/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java: Line 79: } Line 80: returnValue.setFirst(sdStatic); Line 81: Guid storagePoolId = null; Line 82: String[] poolUUIDs = (String[])xmlRpcStruct.get("pool"); Line 83: if (poolUUIDs != null && !poolUUIDs[0].isEmpty()) { > isn't the first check sufficent? do we get to the second case? done Line 84: Guid.createGuidFromString(poolUUIDs[0]); Line 85: } Line 86: returnValue.setSecond(storagePoolId); Line 87: return returnValue; Line 82: String[] poolUUIDs = (String[])xmlRpcStruct.get("pool"); Line 83: if (poolUUIDs != null && !poolUUIDs[0].isEmpty()) { Line 84: Guid.createGuidFromString(poolUUIDs[0]); Line 85: } Line 86: returnValue.setSecond(storagePoolId); > storagePoolId isn't initialized with the pool value.. done Line 87: return returnValue; Line 88: } Line 89: Line 90: @Override -- To view, visit http://gerrit.ovirt.org/29146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ca10fd579b6588d57b7ce590e424ee0f8cf75e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
