Liron Aravot has posted comments on this change. Change subject: core: Change GetStorageDomainInfo return value ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29146/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java: Line 77: .toUpperCase(), Line 78: false)); Line 79: } Line 80: returnValue.setFirst(sdStatic); Line 81: returnValue.setSecond(Guid.createGuidFromString(((String[])xmlRpcStruct.get("pool"))[0])); if the domain has no pool, seems like it will fail with index out of bound exception or npe Line 82: return returnValue; Line 83: } Line 84: Line 85: @Override -- To view, visit http://gerrit.ovirt.org/29146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ca10fd579b6588d57b7ce590e424ee0f8cf75e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
