Alon Bar-Lev has posted comments on this change. Change subject: core: introduce context pattern ......................................................................
Patch Set 34: (2 comments) Moti, thanks for reviewing! I could answer two issues immediately. http://gerrit.ovirt.org/#/c/28829/34/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java: Line 31: protected boolean isRunOnlyIfAllCanDoPass = false; Line 32: Line 33: protected CommandContext commandContext; Line 34: Line 35: public MultipleActionsRunner(VdcActionType actionType, List<VdcActionParametersBase> parameters, CommandContext commandContext, boolean isInternal) { > why set the commandContext via the c'tor and not using the setter ? because it must not be changed once context is created. this is different from all the other properties. Line 36: this.actionType = actionType; Line 37: this.parameters = parameters; Line 38: this.isInternal = isInternal; Line 39: this.commandContext = commandContext; http://gerrit.ovirt.org/#/c/28829/34/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java: Line 48: } Line 49: Line 50: public CommandContext setCompensationContext(CompensationContext compensationContext) { Line 51: this.compensationContext = compensationContext; Line 52: return this; > i'm not familiar with such pattern of setter. this is very nice notation to allow: object.setXXX().setYYY().setZZZ(); well known chaining pattern, we use this in lock[1] patch, as well as the new extension api, look for ExtMap. [1] http://gerrit.ovirt.org/#/c/25944/ Line 53: } Line 54: Line 55: public CommandContext resetCompensationContext() { Line 56: return setCompensationContext(new DefaultCompensationContext()); -- To view, visit http://gerrit.ovirt.org/28829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310f5f77fff78b3232ee77fe63791425fd521516 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
